Question:

Can anyone tell me what's wrong with this code?

by | earlier

<html>

<body>

<script language="Javascript">

colours=new Array("black","white");

index=0;

document.write(<h1>Blinking text</h1>);

ref=setInterval("func()",500);

Function func()

{

if(index>1)

{

index=0;

document.fgcolor=colours[index];

index++;

}

else

{

document.fgcolor=colours[index];

index++;

}

}

</script>

</body>

</html>

Tags:

Report

Answer The Question I've Same Question Too

Follow Question

8 ANSWERS

Sort By: Date | Rating

document.write(<h1>Blinking text</h1>);

->

document.write("<h1>Blinking text</h1>");

Also your if statement will NEVER execute the second block because index can only ever be 0 or 1 (it is reset to 0 by the first block).

Report (0) (0) | earlier
Here's code that I tested that appears to work. There are a couple of things wrong with your logic. The color will always be white after the first time, you need to toggle between 0 & 1 (or if there are more than 2 colors, toggle "index" between 0 & n).

Another thing is you shouldn't rewrite the entire page, which is what "document.write()" will do. Simple leave an element (or elements) on the page, and toggle their color, by modifying their style attribute.

<html>

<HEAD>

<script language="Javascript">

colours=new Array("black","white");

index=0;

function func() {

alert(document.getElementById("myText"...

if(index==1) {

index=0;

document.getElementById("myText").styl...

} else {

index=1;

document.getElementById("myText").styl...

}

//document.write(colours[index]);

ref=window.setTimeout("func()",1000);

}

</script>

</HEAD>

<body onload="func()">

<h1 id="myText">Blinking text</h1>

</body>

</html>
Report (0) (0) | earlier
Know about webdesing tips,tricks and review

of hosting services also post your coment

join

http://smtechnology.freeforums.org/

Report (0) (0) | earlier
I'm not adept at JavaScript, but I do think that your error resides on the if-statement construction that you had. I'll highlight it for you.

Function func()

{

if(index>1)

{

index=0;

document.fgcolor=colours[index];

index++;

}

else

{

document.fgcolor=colours[index];

index++;

}

}

Right, you have initialized index to 0. But, the construction of your if-statement makes it static.

When index = 1, you set it back to 0, and you increment it again. Thus, the program will always evaluate this part, will never leave this part, since index is always 1. Here's the proposed change:

Function func()

{

if(index==1)

{

document.fgcolor=colours[index];

index = 0;

}

else

{

document.fgcolor=colours[index];

index = 1;

}

}

In this way, your program just switches between 0 and 1.

Hope this solves your problem.
Report (0) (0) | earlier
Try function in place of Function. That should remove the error you are getting.

I would also suggest you look into something called jQuery [ http://jquery.com/ ] it allows writing of cross browser supported Javascript. And it it also much easier once you get it.

Another recommendation is to download Firefox [ http://www.mozilla.com/en-US/firefox/ ] and install the Firebug addon [ https://addons.mozilla.org/en-US/firefox... ]. I used Firebug to find the error.
Report (0) (0) | earlier
what are you trying to do?

are you trying to put it on your myspace as a layout?

Report (0) (0) | earlier
dude... if this is for myspace... it wont work because myspace doesnt allow javascript... try using normal HTML code!
Report (0) (0) | earlier
Ok, other answers have gotten pieces of the answer, but here is what I needed to do to get it working:

<html>

<body>

<script language="Javascript">

colours=new Array("black","white");

index=0;

document.write('<h1>Blinking text</h1>');

ref=setInterval("func()",500);

function func()

{

if(index==1)

{

index=0;

document.body.style.color =colours[index];

}

else

{

index=1;

document.body.style.color = colours[index];

}

}

</script>

</body>

</html>

1. Quotes around <h1>Blinking text</h1>

2. "Function" should be lower case "function"

3. Change the way index is evaluated

4. Use document.body.style.color instead of document.fgcolor which has been deprecated.

Report (0) (0) | earlier